[ ] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.
Changes to resolve #16.
When I created #16, I forgot about an additional Karney test case for testing arc-mode direct. I went ahead and included that in this PR as well, but can take it back out. That change includes making a previously in-test array a const, and adds a roughly 30 line test, on top of the 450 line estimate I gave originally. Sorry about that oversight.
Some of the new tests fail for existing code. Because the tests come with predefined acceptance criteria, I wasn't excited to just inflate the accepted tolerance as I did for the previous batch, but I would be willing to do that if you prefer. This draft flags the failing tests as ignored. What would you like in these situations?
bors[bot]
commented
3 years ago
[ ] I added an entry to
CHANGES.mdif knowledge of this change could be valuable to users.Changes to resolve #16.
When I created #16, I forgot about an additional Karney test case for testing arc-mode direct. I went ahead and included that in this PR as well, but can take it back out. That change includes making a previously in-test array a const, and adds a roughly 30 line test, on top of the 450 line estimate I gave originally. Sorry about that oversight.
Some of the new tests fail for existing code. Because the tests come with predefined acceptance criteria, I wasn't excited to just inflate the accepted tolerance as I did for the previous batch, but I would be willing to do that if you prefer. This draft flags the failing tests as ignored. What would you like in these situations?