michaelkirk
commented
3 years ago bors r+
Great!
On Feb 2, 2021, at 23:26, stonylohr notifications@github.com wrote:
Short version: At this point, it just needed to be unignored.
Previously affected by some direct bugs that were fixed as part of earlier commits. An earlier draft accidentally used too demanding of a tolerance for some parameters, also fixed in previous commits, but I had forgotten to merge that tolerance update into my test-heavy "establish-baselines" branch. My polyval suspicion turned out to be a red herring related to array comparisons where I had forgotten that the first element is unused and therefore shouldn't be checked.
I agree to follow the project's code of conduct. I added an entry to CHANGES.md if knowledge of this change could be valuable to users. You can view, comment on, or merge this pull request online at:
https://github.com/georust/geographiclib-rs/pull/40
Commit Summary
Unignore test_arcdirect File Changes
M src/geodesic.rs (1) Patch Links:
https://github.com/georust/geographiclib-rs/pull/40.patch https://github.com/georust/geographiclib-rs/pull/40.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.
bors[bot]
Short version: At this point, it just needed to be unignored.
Previously affected by some direct bugs that were fixed as part of earlier commits. An earlier draft accidentally used too demanding of a tolerance for some parameters, also fixed in previous commits, but I had forgotten to merge that tolerance update into my test-heavy "establish-baselines" branch. My polyval suspicion turned out to be a red herring related to array comparisons where I had forgotten that the first element is unused and therefore shouldn't be checked.
[ ] I added an entry to
CHANGES.mdif knowledge of this change could be valuable to users.