Closed dabreegster closed 1 year ago
Hrmm... my inline comment got lost in the ether.
What would you think about changing the API slightly to avoid building up the intermediate JsonObject just to pass it in?
pub fn write_foreign_member(&mut self, key: &str, foreign_member: &JsonValue) -> Result<()>;
What would you think about changing the API slightly to avoid building up the intermediate JsonObject just to pass it in?
Good idea, done. It was an odd API before to only allow one of the calls. Writing one key at a time is much nicer.
This gets a little nicer to use if we allow the same value types as serde_json::to_writer.
Good point, thanks! Done
CHANGES.md
if knowledge of this change could be valuable to users.