Closed gibbz00 closed 11 months ago
Hmmm... I haven't worked with this code for a bit, but I'm surprised that you'd need a custom deserialization method for this.
You can already do an Option<Geometry>
with vanilla serde derive, right? I wonder why that wouldn't work for Point
or the other Geometry enums 🤔
I'm sorry, I missed that this was about geo-types. I think the approach makes sense. 👍
Sounds good 😊
Note to self and other maintainers... the merge queue (which we recently adopted) seemed to merge this branch immediately without waiting for tests to complete (though the tests ultimately did pass, so no worries).
I updated a couple settings which I think we were missing, so it should work next time. 🤞
Most importantly the "require status checks" setting:
I also enabled "require PR before merging" like we do in geoerust/geo.:
Before
After:
CHANGES.md
if knowledge of this change could be valuable to users.