search

georust / geos

Rust bindings for GEOS
https://docs.rs/geos/
MIT License
122 stars 41 forks source link

TST: Update tests to pass on GEOS 3.6 - 3.11 #115

Closed brendan-ward closed 2 years ago

brendan-ward commented 2 years ago

This updates and simplifies the tests that were breaking on GEOS > 3.6 so that they run on all versions 3.6 - 3.11.

I understand that some of the doctests use geometires from the PostGIS documentation. However, these are more complex than necessary for simple examples, so I simplified these down for clarity and to ensure they pass.

brendan-ward commented 2 years ago

Still in progress: all tests passed locally on MacOS but some are still failing on CI / Ubuntu.

brendan-ward commented 2 years ago

Tests are failing on CI for unrelated reasons and need to be rerun.

Latest test results here: https://github.com/brendan-ward/geos-rs/runs/7682381950

All tests except memory leaks (existing issue) now passing on all GEOS versions 3.6 - 3.11.

GuillaumeGomez commented 2 years ago

Quickly commenting to say I saw the PR. Will review it whenever I can.

GuillaumeGomez commented 2 years ago

Looks great, thanks!