georust / geos

Rust bindings for GEOS
https://docs.rs/geos/
MIT License
122 stars 41 forks source link

Fix 'from_geo' example in README #124

Closed mthh closed 1 year ago

mthh commented 1 year ago

This fixes the 'from_geo' example in the README (and so in the doc generated by cargo doc, as it includes the README) by removing the use geos::from_geo::TryInto; statement (otherwise cargo complains that this trait is private).

GuillaumeGomez commented 1 year ago

Considering it's ignore, it shouldn't be compiled so I'm a bit surprised. But thanks for the fix in any case!

mthh commented 1 year ago

Indeed, but a user might want to copy/paste the example from the README / from the doc (and thus come across this error - that's how I found it).

GuillaumeGomez commented 1 year ago

Absolutely, hence why I'm approving this PR. Thanks again!