search

georust / geos

Rust bindings for GEOS
https://docs.rs/geos/
MIT License
122 stars 41 forks source link

Removed unnecessary lifetimes #153

Closed ManeraKai closed 4 months ago

ManeraKai commented 4 months ago

Fixes https://github.com/georust/geos/issues/152 and 2) Lifetimes part of https://github.com/georust/geos/issues/141

kylebarron commented 4 months ago

I haven't fully read through the diff yet but this looks awesome and I'm really excited for this. (With the caveat that I don't know C FFI well enough to know if there's any relation between removing named lifetimes and FFI safety). In geoarrow-rs I've struggled around GEOS lifetimes a decent amount with conversions to/from geoarrow.

GuillaumeGomez commented 4 months ago

Looks good to me, thanks a lot! Please run cargo fmt. You can ignore the memory leaks failures in the CI.

GuillaumeGomez commented 4 months ago

Gonna make a new release "soon".

ManeraKai commented 4 months ago

We are using geos for a university project. Please make it more "soon".

michaelkirk commented 4 months ago

If it's really so urgent you can patch your dependency.

GuillaumeGomez commented 4 months ago

We are using geos for a university project. Please make it more "soon".

For faster things, you can sponsor me. Otherwise, please be patient or follow @michaelkirk great advice.

ManeraKai commented 4 months ago

Alright.

GuillaumeGomez commented 4 months ago

Released the new 9.0.0 version.