search

georust / geos

Rust bindings for GEOS
https://docs.rs/geos/
MIT License
122 stars 42 forks source link

Improvements #42

Closed GuillaumeGomez closed 5 years ago

GuillaumeGomez commented 5 years ago

Updated.

TeXitoi commented 5 years ago

I'll rewrote all of that with map_err and ? personally.

Le 11 avril 2019 16:49:13 CEST, Guillaume Gomez notifications@github.com a écrit :

GuillaumeGomez commented on this pull request.

@@ -96,7 +97,7 @@ impl<'a> CoordSeq<'a> { if !data.iter().skip(1).all(|x| x.len() == dims) { return Err(Error::GenericError("All vec entries must have the same size!".to_owned())); }

  • match match GContextHandle::init() {
  • match GContextHandle::init() {

You're asking a bit too much of me! I love matches. :'(

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/georust/geos/pull/42#discussion_r274462889

-- Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.

GuillaumeGomez commented 5 years ago

This PR is big enough as is. Next step: splitting FFI part from this crate.

@TeXitoi: I'm not a big fan of that but if you want it, please open a PR. :)

mthh commented 5 years ago

@GuillaumeGomez I havent been able to follow your PRs very closely but thank you for all the work in improving that library !

TeXitoi commented 5 years ago

I dont really care that's just style.

GuillaumeGomez commented 5 years ago

@mthh No problem and you're welcome! ;)

GuillaumeGomez commented 5 years ago

@TeXitoi Style is important so feel free to apply yours anytime. :p