search

georust / geos

Rust bindings for GEOS
https://docs.rs/geos/
MIT License
122 stars 42 forks source link

minor cleanup: remove area and _type from Geom #8

Closed antoine-de closed 6 years ago

antoine-de commented 6 years ago

it was not mandatory to store them in the geometry, they can be computed on the fly to we remove those 2 fields.

And use the enum GeometryType not to carry i32 around.

mthh commented 6 years ago

Hi!

This looks good to me! Thanks!

I thought you had the rights to merge PR and other stuff on this repository. I put the whole georust "core" team with the "admin" rights on this repository (as for other repo georust I think? or feel free to tell me if it is customary to do otherwise!) Also don't hesitate to merge next PRs.

antoine-de commented 6 years ago

yes I have the rights but it's nice for another to review them, thank you very much !

mthh commented 6 years ago

Sure I completely agree, don't hesitate! (I said this mainly not to delay your progress unnecessarily!)