search

georust / geos

Rust bindings for GEOS
https://docs.rs/geos/
MIT License
122 stars 42 forks source link

crates publishing team #80

Closed michaelkirk closed 2 years ago

michaelkirk commented 3 years ago

👋 Hi @GuillaumeGomez and @antoine-de, you two are the only "user-owners" of the geos crate on crates.io, so only you can edit that crate's owners on crates.io.

Following up on https://github.com/georust/meta/pull/21, I created a new geos-publishers team for publishing to crates.io with you as maintainer.

Could you please update the crate owners? Specifically:

cd geos

# 💥 remove large publishing team
cargo owner --remove github:georust:core

# 🔐 add small publishing team
cargo owner --add github:georust:geos-publishers

# make sure everything looks good 👀 
cargo owner --list
cd geos

# 💥 geos-sys didn't have the georust/core team as a team-owner
# 🔐 add small publishing team (assuming you'd prefer to share a publishing team between geos and geos-sys crates)
cargo owner --add github:georust:geos-publishers

# 🚨 @GuillaumeGomez: note that you are the *sole* user-owner of the geos-sys crate. 
# Consider adding another user-owner so that someone can still update the crate owners if you become inaccessible. Maybe @antoine-de?
cargo owner --add antoine-de

# make sure everything looks good 👀 
cargo owner --list

If there's anyone else you'd like to be able to publish the crates, feel free to add them to your publishing team, or as a user-owner. Consider that user-owners, as opposed to owners-via-team, can themselves edit the crate's owners, which could be desirable, or not, depending.

Once you switch the publishing team, no one else will be able to publish until either they are added to the new publishing team or added as a user-owner.

Let me know if you have any questions, or you can review https://github.com/georust/meta/pull/21.

GuillaumeGomez commented 3 years ago

I'll when there will be another maintainer showing up. :)

frewsxcv commented 3 years ago

@GuillaumeGomez can you clarify what you mean?

GuillaumeGomez commented 3 years ago

Sure: what I meant is simply that I don't think handing the maintenance to a team is a good idea. However, if someone contributes to geos crates, I have no issue to add them as well (that's what I did for gtk-rs). Currently we are two already, so the chances of both of us disappearing at the same time is quite low.

frewsxcv commented 3 years ago

@GuillaumeGomez there seems to be a misunderstanding of this GitHub Issue. the goal of this is to limit, not expand, who can publish the geos crate. currently everyone in the georust github organization can publish it. when you have some time, please read https://github.com/georust/meta/pull/21.

GuillaumeGomez commented 3 years ago

Oh! My bad. Then I'll do shortly. Sorry for the misunderstanding...

GuillaumeGomez commented 3 years ago

I get the following error:

$ cargo owner --remove 'github:georust:core'
    Updating crates.io index
       Owner removing ["github:georust:core"] from crate geos
error: failed to remove owners from crate geos

Caused by:
  api errors (status 200 OK): could not find the github team georust/core

$ cargo owner --list
    Updating crates.io index
GuillaumeGomez (Guillaume Gomez)
antoine-de (Antoine D)
github:georust:core (Core)
frewsxcv commented 3 years ago

weird. @GuillaumeGomez can you try making the changes in the UI here? https://crates.io/crates/geos/owners

GuillaumeGomez commented 3 years ago

And done! Closing it then. (and thanks for the link!)

frewsxcv commented 3 years ago

looks like georust/core is still an owner: https://crates.io/crates/geos/owners

i wonder if this is a crates.io bug?

GuillaumeGomez commented 3 years ago

Ah you're right! I got the message saying it was removed though... Opening an issue for them then.

GuillaumeGomez commented 2 years ago

The team was removed successfully from the owners list. Closing then.