georust / geozero

Zero-Copy reading and writing of geospatial data.
Apache License 2.0
352 stars 37 forks source link

Resolve some default-warn clippy lints in the geozero-shp crate #103

Closed rye closed 1 year ago

rye commented 1 year ago

Some of the code of the geozero-shp crate was copied over from shapefile-rs in 08ef12816e3f3aa2b4a5b148b22927f1399cd0c6. As-is, that code has some clippy warnings in the clippy::all set. This makes hacking on the geozero-shp crate a bit cumbersome, as it's hard to just call cargo clippy and know whether your changes introduced new clippy lints.

The changes in this PR seem to — for the most part, at least — apply to those parts that were copied over. I didn't individually git-blame to verify this, but I didn't encounter anything geozero-specific in the changes I made.

I also intentionally kept this PR very sparse (only making minimal changes so as to resolve clippy lints). I aim to follow up with another PR that does more cleanup, hopefully to include some more intense refactoring and full documentation.

rye commented 1 year ago

A couple of addenda:

pka commented 1 year ago

Thanks a lot! I'm fine with any clippy fix and a CI workflow would be helpful, indeed!