search

georust / geozero

Zero-Copy reading and writing of geospatial data.
Apache License 2.0
352 stars 37 forks source link

address latest clippy lints (from rust-1.73) #178

Closed michaelkirk closed 10 months ago

michaelkirk commented 11 months ago

Fixes lint failures like this:

warning: unneeded `return` statement with `?` operator
   --> geozero/src/mvt/mvt_reader.rs:261:13
    |
261 |             return Err(MvtError::GeometryFormat)?;
    |             ^^^^^^^ help: remove it
michaelkirk commented 11 months ago

Hm... cargo +nightly check is failing against some of our dependencies.

It might be a legitimate problem or might just be some problem with nightly.

Do we really want to be running +nightly as part of our CI?

nyurik commented 11 months ago

The nightly check was intended for something else -- to catch config errors like these examples. It is only available in nightly. We should probably disable any other linting warnings though to reduce the noise levels

michaelkirk commented 10 months ago

I don't think the tradeoff for running cargo +nightly check is worth the value of linting typos in our cfgs, so I've proposed removing it: c3f76cf0a6455109b43d0e11522d0164e18c9dc1

What do other people think?

If someone else (@nyurik?) wants to fix the broken check to be more robust, I'd also be fine to keep it.

frewsxcv commented 10 months ago

+1 to not running nightly in CI. Nightly breaks things regularly enough that's it's not worth the tradeoff IMHO

nyurik commented 10 months ago

sounds good to me too - config check should probably be commented out until it becomes stable to remind us to re-enable it? Unless it will be part of the warnings by default(?)