search

georust / geozero

Zero-Copy reading and writing of geospatial data.
Apache License 2.0
321 stars 30 forks source link

make `with-gdal` feature require `gdal-sys` #212

Closed kylebarron closed 1 month ago

kylebarron commented 1 month ago

gdal-sys is its own optional dependency, and currently with-gdal does not require it. That means that any import of gdal-sys from geozero will fail without the user turning on an explicit gdal-sys feature, see #211. So e.g. this fails:

https://github.com/georust/geozero/blob/8f3d8e4b9363aee0d50356936f5be65f496b9953/geozero/src/gdal/gdal_error.rs#L2

I don't see why with-gdal wouldn't turn on gdal-sys.

Closes https://github.com/georust/geozero/issues/211

kylebarron commented 1 month ago

Oh oops. Well I did approve the previous PR so I'm also at fault 🙂