Closed michaelkirk closed 2 years ago
Ok, I believe I've responded to all your feedback @pka.
The last remaining thing is if you're OK to continue to fail hard when encountering an invalid WKT.
That's my preference, but I'd be open to some kind of --strict
/--no-strict
configuration that gets passed into the reader.
Thanks!
One point was maybe a misunderstanding. I include the macro with use log::warn
and then also log with warn!("...")
. But that's nitpicking.
I'm fine with both hard failing on a WKT error or skipping with warning. Was just not sure whether it was intentional. I let you decide.
Could you please squash the CSV commits for merging?
Squashed!
The reader portion of #24.
I've hit a bump while working on the writer portion, so that might need to wait a bit. Also, if I'm being honest, I only personally need the reader portion at the moment, so am being lazy. 😄