Closed frewsxcv closed 1 year ago
@pka Do the latest commits look okay?
@pka @michaelkirk This is ready for another review
The outputs in the tests look ok to me. Could you please "fix" them and reduce the git commits?
The outputs in the tests look ok to me. Could you please "fix" them and reduce the git commits?
Done
reduce the git commits?
Can we just use the "Squash and merge" feature in the GitHub pull request?
reduce the git commits?
Can we just use the "Squash and merge" feature in the GitHub pull request?
I'm afraid that @michaelkirk's commits are lost with "Squash and merge", so a manual git rebase -i
session is needed.
FWIW - I'm happy to see this get merged with or without my commits staying in tact. Go wild!
https://github.blog/changelog/2019-12-19-improved-attribution-when-squashing-commits/
Before today, whoever opened the pull request became the sole author of the squash commit. Now, we will automatically credit every commit author in the pull request as a co-author on the squash commit.
GitHub will attribute everyone in the PR
Fixes https://github.com/georust/geozero/issues/47
This adds a
GeomProcessor
for GPX files