search

georust / geozero

Zero-Copy reading and writing of geospatial data.
Apache License 2.0
336 stars 33 forks source link

GPX read support #48

Closed frewsxcv closed 1 year ago

frewsxcv commented 1 year ago

Fixes https://github.com/georust/geozero/issues/47

This adds a GeomProcessor for GPX files

frewsxcv commented 1 year ago

@pka Do the latest commits look okay?

frewsxcv commented 1 year ago

@pka @michaelkirk This is ready for another review

pka commented 1 year ago

The outputs in the tests look ok to me. Could you please "fix" them and reduce the git commits?

frewsxcv commented 1 year ago

The outputs in the tests look ok to me. Could you please "fix" them and reduce the git commits?

Done

frewsxcv commented 1 year ago

reduce the git commits?

Can we just use the "Squash and merge" feature in the GitHub pull request?

pka commented 1 year ago

reduce the git commits?

Can we just use the "Squash and merge" feature in the GitHub pull request?

I'm afraid that @michaelkirk's commits are lost with "Squash and merge", so a manual git rebase -i session is needed.

michaelkirk commented 1 year ago

FWIW - I'm happy to see this get merged with or without my commits staying in tact. Go wild!

frewsxcv commented 1 year ago

https://github.blog/changelog/2019-12-19-improved-attribution-when-squashing-commits/

Before today, whoever opened the pull request became the sole author of the squash commit. Now, we will automatically credit every commit author in the pull request as a co-author on the squash commit.

GitHub will attribute everyone in the PR