search

georust / gpx

Rust read/write support for GPS Exchange Format (GPX)
https://crates.io/crates/gpx
MIT License
102 stars 46 forks source link

Update documentation to include write examples #100

Closed wtchen closed 1 year ago

wtchen commented 1 year ago

Fixes https://github.com/georust/gpx/issues/98

wtchen commented 1 year ago

Can someone review? 🙂 cc @lnicola

wtchen commented 1 year ago

Thanks for the review, great suggestions. I'm new to this library and Rust generally, so I'll defer to your suggestions. I'll push the changes in the next couple of days, hopefully by the end of this coming weekend.

wtchen commented 1 year ago

Ok, code has been updated! May you take a look when you get a chance, @lnicola?

wtchen commented 1 year ago

Done :-) ... can you take a look again @lnicola ?

lnicola commented 1 year ago

Thanks and sorry for the back and forth!

bors r+

bors[bot] commented 1 year ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

wtchen commented 1 year ago

Thanks and sorry for the back and forth!

No worries, thanks for the comments, it's helping me learn good practices in Rust 🙂