georust / gpx

Rust read/write support for GPS Exchange Format (GPX)
https://crates.io/crates/gpx
MIT License
98 stars 44 forks source link

Replace error_chain with ThisError #58

Closed urschrei closed 3 years ago

urschrei commented 3 years ago

Greatly expand defined errors, and remove all ad-hoc error messages

lnicola commented 3 years ago

Looks fine, though to be honest in a library like this I'd prefer a hand-rolled error enum. They're not that much harder to write and build times are much lower unless you're already using proc macros.

urschrei commented 3 years ago

I suppose so although we have some crates in the georust ecosystem using thiserror, so there's a reasonable chance it's already in the tree.

urschrei commented 3 years ago

(Not geo or geo-types, though. Not yet)

michaelkirk commented 3 years ago

LGTM!

urschrei commented 3 years ago

bors r+

bors[bot] commented 3 years ago

Build succeeded: