georust / gpx

Rust read/write support for GPS Exchange Format (GPX)
https://crates.io/crates/gpx
MIT License
102 stars 46 forks source link

Add `xmlns` attribute in written gpx for better garmin compatibility #67

Closed OttoBos closed 2 years ago

OttoBos commented 2 years ago

I noted that the exported GPX files are not accepted by Garmin software (for example Basecamp), and found out this is due to a missing namespace declaration. This PR adds the necessary xmlns tag to the gpx element.

urschrei commented 2 years ago

bors try

bors[bot] commented 2 years ago

try

Build failed:

urschrei commented 2 years ago

CI failure caused by Time's MSRV of 1.53. Hopefully fixed in https://github.com/georust/gpx/pull/68 when it merges.

urschrei commented 2 years ago

bors try

bors[bot] commented 2 years ago

try

Build succeeded:

urschrei commented 2 years ago

bors r+

urschrei commented 2 years ago

Thanks for your contribution @OttoBos!

bors[bot] commented 2 years ago

Build succeeded: