Closed oppiliappan closed 2 years ago
The field should probably be public as well? Or it could have an into_inner()
or impl From<Time> for time::OffsetDateTime
, because otherwise you won't be able to do anything with it.
yep, that too, currently i am just using it to compare two times, which is possible with just making it public, but anything else will require being able to convert to OffsetDateTime
@lnicola would you prefer if i create an into_inner
or a From<Time> for OffsetDateTime
?
No strong opinion, since both expose the internal representation. I suppose From
is slightly more idiomatic. Let's see what the maintainers think (I'm around only incidentally, I've never used this crate).
Likewise, I do like From
more.
This LGTM FWIW.
I'd say you are the most active maintainer in this repo @lnicola, so I think it makes sense to merge it if you think it looks good.
bors r+
bors r-
Canceled.
bors r=michaelkirk,lnicola
[ ] I added an entry to
CHANGELOG.md
if knowledge of this change could be valuable to users.not sure if this is intentionally private, perhaps there is some other way to access time data from waypoints directly as chrono types?
closes #75 if valid