Closed 0b11001111 closed 2 years ago
r? @urschrei
I added a few more changes to make my linter happy and thereby found a bug in the parsing logic for tracks. On my machine, all unit and integrations tests pass :)
I will later add another test case using the file exported from outdooractive.com that originally caused the RFC 3339 parsing error
Sorry for taking so long to look at this again, but can you replace the new test file with a smaller version (1-2 points or whatever)? I know that some of the other fixtures are already quite large, but it seems somewhat excessive and maybe we can not add another one?
You're right, I filtered most waypoints out in https://github.com/georust/gpx/pull/78/commits/d3375a47a2eed0e582d52b152b8408a4366066cd
Thanks. Can you also squash, since there's not much benefit in trimming down the file otherwise? :smile: (I can do it if you don't know how to)
I was today years old when I learned...
Hope I did the right thing :D
@bors r+
Huh
bors ping
pong
bors r+
Ah, this isn't your fault, we need to test with newer compiler versions.
Ah, this isn't your fault, we need to test with newer compiler versions.
I just now opened https://github.com/georust/gpx/pull/80 to address this.
bors retry
Merge conflict.
I took the liberty of fixing the conflicts in the change log.
bors retry
[x] I added an entry to
CHANGELOG.md
if knowledge of this change could be valuable to users.Implement changes proposed in https://github.com/georust/gpx/issues/77
I don't expect this to land directly as it adds a breaking change