georust / gpx

Rust read/write support for GPS Exchange Format (GPX)
https://crates.io/crates/gpx
MIT License
102 stars 46 forks source link

Optimize deps: Drop `error_chain` and move `assert_approximate_eq` to dev-deps #91

Closed w-flo closed 1 year ago

w-flo commented 1 year ago

I'm not sure how valuable a changelog entry for this would be for users, and English is not my native language. So I haven't added one. Let me know if I should, or feel free to add it yourself if you want :-)

I've noticed these deps do not appear to be needed. The error_chain dependency seems especially "wasteful" because it brings in a bunch of transitive dependencies. Commit messages:


Move `assert_approx_eq` crate to dev-dependencies

The crate is used in two test cases and appears not to be needed
otherwise.

Remove error_chain remnants

The code no longer depends on error_chain since #58, but the dependency
was still listed in Cargo.toml. There still was one commented-out "use"
directive.

Drops the number of build steps from 69 to 48, and helps with
compilation time a bit.
michaelkirk commented 1 year ago

Thanks!

bors r+

bors[bot] commented 1 year ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.