Closed w-flo closed 1 year ago
Thanks for the review @lnicola :-)
bors r+
Thanks for the MSRV bump! I rebased this PR just now
Thanks!
bors r+
Build succeeded!
The publicly hosted instance of bors-ng is deprecated and will go away soon.
If you want to self-host your own instance, instructions are here. For more help, visit the forum.
If you want to switch to GitHub's built-in merge queue, visit their help page.
[X] I added an entry to
CHANGELOG.md
if knowledge of this change could be valuable to users.I've sneaked in a second commit in this PR, to add a changelog entry for my previous PR that was merged without a changelog entry. After looking at the changelog, it seems like my previous decision to skip adding an entry was incorrect (the change probably was more important for users than CI rust version bumps).
Open question for this change: Should
<text></text>
result intext = Some("")
ortext = None
? I like the currentSome("")
approach since I suspect some applications use this crate to read, change and then write GPX files. IfSome("")
was changed toNone
through some magic, the resulting GPX file would have the<text></text>
removed. There would also be some (arguably mostly irrelevant) loss of information ("is there an empty text tag or no text tag?") when reading a GPX file. However, changing it toNone
might be helpful for applications since most would probably want to treat an emptry string the same as no string. I'd be fine with both approaches.