georust / netcdf

High-level netCDF bindings for Rust
Apache License 2.0
81 stars 28 forks source link

Flatten import structure #122

Closed magnusuMET closed 7 months ago

magnusuMET commented 7 months ago

Removes visible modules (leaving types) to make the documentation clearer.

This is a breaking change and may require crate users to update their code

lnicola commented 7 months ago

An alternative here, which might be preferred, is to keep using the nested structure, but make it private and add re-exports. Probably doesn't matter too much though.

magnusuMET commented 7 months ago

@lnicola not entriely sure I understand wat you are suggesting. This change does make most modules private and only changes the public API by moving items to the top-level.

lnicola commented 7 months ago

wat you are suggesting

Exactly what you did, sorry :pensive:.

magnusuMET commented 7 months ago

We have the same idea for how to structure this crate, which is great! 🙂