search

georust / netcdf

High-level netCDF bindings for Rust
Apache License 2.0
81 stars 28 forks source link

Replace `strlcat` symbol in vendored netcdf source code with a prefixed version #138

Closed weiznich closed 3 months ago

weiznich commented 3 months ago

This PR adds another patch to the vendored version of the netcdf source code to replace the strlcat symbol with vendored version to prevent duplicated symbols at the linking stage if any other dependency also includes a vendored version of strlcat. This is essentially https://github.com/Unidata/netcdf-c/pull/2906, but adjusted to the vendored version (the function definition is in a different file). I found this issue while working on the CI setup for https://github.com/georust/gdal/pull/517 (that PR is essentially blocked on this one now…)

magnusuMET commented 3 months ago

Thanks! Just released netcdf-src-v0.3.3 which includes this fix

weiznich commented 3 months ago

Thanks for the fast turnaround :heart:

That's really appreciated.