georust / proj

Rust bindings for the latest stable release of PROJ
https://docs.rs/proj
Apache License 2.0
137 stars 44 forks source link

Fix #101 Add convert methods for all the types from geo-types #106

Closed x4d3 closed 2 years ago

x4d3 commented 2 years ago

I though it would be handy/nice to be able to convert all the types from geo-types, from one system of coordinate to the other.

This PR is an attempt at doing that.

Please let me know if it's out of scope, completely wrong, etc..

Fix #101

frewsxcv commented 2 years ago

@x4d3 Cool! In case you didn't already see: https://github.com/georust/geo/pull/718

michaelkirk commented 2 years ago

Hi @x4d3! Thanks for the PR.

I think this is a plausibly useful feature, thanks for proposing it.

Funny timing - as @frewsxcv linked, we just added something very similar to the geo crate in https://github.com/georust/geo/pull/718.

Before commenting on any of your specific code, I wanted to strategize on the relationship between all these crates, so we don't end up re-inventing slightly different wheels.

See here: https://github.com/georust/proj/issues/108

x4d3 commented 2 years ago

Closing in favor of #109