georust / proj

Rust bindings for the latest stable release of PROJ
https://docs.rs/proj
Apache License 2.0
137 stars 44 forks source link

Make PjInfo struct public #133

Closed urschrei closed 2 years ago

urschrei commented 2 years ago

Fixes #131

urschrei commented 2 years ago

I've merged #134, but even though there's now a proj::proj_info method which returns a proj::ProjInfo struct, it's not visible in docs, and neither is the struct definition. I feel like I'm losing my mind.

michaelkirk commented 2 years ago

even though there's now a proj::proj_info method which returns a proj::ProjInfo struct, it's not visible in docs, and neither is the struct definition.

Addressed in #136

I feel like I'm losing my mind.

Yes, this is pretty maddening. 😆 I know it was my suggestion, but upon reflection, even though it's an idiomatic translation, proj.info() is a pretty rough name. What would you think about renaming proj.info() to something like proj.lib_info()?

I think that would contrast better with proj.proj_info().

// get details about the libproj installation
proj.lib_info();

// get details about this specific transformation
proj.proj_info();
urschrei commented 2 years ago

Yeah I think that's much clearer! Do you want to leave #136 as is, and I'll merge it tomorrow then do the rename in here?

michaelkirk commented 2 years ago

SGTM!

urschrei commented 2 years ago

OK, this is done!

urschrei commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded:

michaelkirk commented 2 years ago

Good job getting this merged! Sorry for turning it into such an odyssey. 😬

urschrei commented 2 years ago

No, I'm very happy with where it ended up, so def worth it, I think!