search

georust / proj

Rust bindings for the latest stable release of PROJ
https://docs.rs/proj
Apache License 2.0
137 stars 44 forks source link

some tiff users dont need network #143

Closed michaelkirk closed 1 year ago

michaelkirk commented 1 year ago

FIXES #140

I don't really have this use case, so I haven't tested it (hence the draft status).

@burleight - will this satisfy your use case or is there some other API that needs to be exposed as well? Would you be willing to give this a try?

burleight commented 1 year ago

@michaelkirk - yes, that helps with my use case.

I've tried the branch using proj-sys with features = ["tiff"] and can confirm it works as expected.

michaelkirk commented 1 year ago

Sorry to be obtuse, but can you confirm that it does not work as expected with current main? In other words, I'm trying to verify that this PR actually does something useful.

burleight commented 1 year ago

Yes. Using main without "network", my tests fail.

If I use this branch with "tiff" they pass

michaelkirk commented 1 year ago

Yes. Using main without "network", my tests fail.

If I use this branch with "tiff" they pass

Well, alright. Thanks for the feedback!

What do you think @urschrei, worth merging?

urschrei commented 1 year ago

Yep let's do it.

michaelkirk commented 1 year ago

I think that's a:

bors r=urschrei

bors[bot] commented 1 year ago

Build succeeded: