search

georust / proj

Rust bindings for the latest stable release of PROJ
https://docs.rs/proj
Apache License 2.0
137 stars 43 forks source link

Update to libproj 9.2.1 #166

Closed urschrei closed 1 year ago

urschrei commented 1 year ago

(Draft for now because we'll have to update CI)

michaelkirk commented 1 year ago

Want me to take a pass at updating CI?

urschrei commented 1 year ago

I'm about to open a PR against CI, as it looks like your (delightful) regen script worked. It'd be great if you could have a quick look for sanity and then I can kick off the build / test / publish step, as I now have some more computing power so it might not be massively onerous…

urschrei commented 1 year ago

https://github.com/georust/docker-images/pull/24

urschrei commented 1 year ago

well, something is definitely Wrong with the new 1.70 image.

urschrei commented 1 year ago

If I had to guess, it's because the 1.63 images are based on the image that was present on Docker Hub, and its architecture is linux/amd64 whereas subsequent images including the 1.70 ones, are linux/arm64/v8/ (I assume because I built them on an Apple M). Ugh.

michaelkirk commented 1 year ago

Ah yes! I hadn’t really thought of it, but I’ve been doing builds on amd64.Want me to kick off a set of builds?

urschrei commented 1 year ago

Yes but no rush! It's Sunday!

michaelkirk commented 1 year ago

bors retry

Sorry for the delay, holidays in the US.

urschrei commented 1 year ago

I'm confused about this failure.

michaelkirk commented 1 year ago

I realized there was a terrible bug in that I wasn't correctly handling proj upgrades w/o clobbering the existing tag. I think I've fixed it but I'm re-running the container builds locally now. If it works I'll update the docs, push, and retest here.

urschrei commented 1 year ago

bors r=michaelkirk

bors[bot] commented 1 year ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.