Delete bors.toml in favor of GitHub merge queues

georust / proj

Rust bindings for the latest stable release of PROJ

https://docs.rs/proj

Apache License 2.0

137 stars 43 forks source link

Closed frewsxcv closed 11 months ago

michaelkirk commented 11 months ago

🤔 It seems like it's merging directly to main and only running the tests after. Or am I confused?

urschrei commented 11 months ago

Ughhhhhh I just replicated what we used in GeoJSON. Blast.

frewsxcv commented 11 months ago

I wonder if it's because we have this specified:

  push:
    branches:
      - main
      - staging
      - trying

Which means CI won't run on other branches, like the temporary branch it creates for the queue

urschrei commented 11 months ago

The other difference with geojson is that we aren't using an "aggregator" job the way we do in proj and geo…

urschrei commented 11 months ago

That shouldn't make a difference, but who knows.

michaelkirk commented 11 months ago

I feel like this isn't supposed to be hard, but I can't figure out what we're doing wrong. 😭

michaelkirk commented 11 months ago

Ohhhhh, well this was disabled. I've enabled it now.

urschrei commented 11 months ago

Ohhhhh

michaelkirk commented 11 months ago

well this was disabled. I've enabled it now.

That setting is actually confusing to me. It didn't solve the problem and I'm not sure what it does.

I think what we want is the "only merge non-failing pull requests" but that was already checked. 🤷