home crate (bindgen dependency) requires MSRV 1.70

georust / proj

Rust bindings for the latest stable release of PROJ

https://docs.rs/proj

Apache License 2.0

137 stars 43 forks source link

home crate (bindgen dependency) requires MSRV 1.70 #187

Closed urschrei closed 6 months ago

urschrei commented 6 months ago

Bindgen hasn't pinned its version of home, and the latest version (https://crates.io/crates/home/0.5.9) has an MSRV of 1.70, which is causing our CI to fail as its minimum version is 1.65

michaelkirk commented 6 months ago

Any reason to not just bump MSRV to 1.70? It was released over 6 months ago.

urschrei commented 6 months ago

No I'm OK with that – we've never made any explicit guarantees about minimum Rust versions (have we?)

urschrei commented 6 months ago

Fixed by #188

michaelkirk commented 6 months ago

I don't know that we've made any promises in this repo, but in geo we say:

"stable + 3", so we support 4 releases, or "about 6 months".

And I pretty much follow that in practice everywhere, though I don't proactively bump MSRV, and usually wait until something breaks.