search

georust / proj

Rust bindings for the latest stable release of PROJ
https://docs.rs/proj
Apache License 2.0
138 stars 45 forks source link

enable network test for ci #38

Closed michaelkirk closed 4 years ago

michaelkirk commented 4 years ago

WDYT @urschrei?

urschrei commented 4 years ago

Yes this is a good plan, and further motivation to do something about the CI setup, ~15 mins per matrix entry is horrible.

michaelkirk commented 4 years ago

rebased

urschrei commented 4 years ago

bors r+

bors[bot] commented 4 years ago

Build failed:

urschrei commented 4 years ago

Bors retry

bors[bot] commented 4 years ago

Canceled.

michaelkirk commented 4 years ago

bors retry

bors[bot] commented 4 years ago

:lock: Permission denied

Existing reviewers: click here to make michaelkirk a reviewer

michaelkirk commented 4 years ago

😭

urschrei commented 4 years ago

Just enabled bors for you @michaelkirk

michaelkirk commented 4 years ago

bors retry

bors[bot] commented 4 years ago

Build failed:

michaelkirk commented 4 years ago

I completely forgot about this PR. 😅

michaelkirk commented 4 years ago

I'm going to pause this for a second to get feedback on #39 since it affects the direction I'd take on this.

michaelkirk commented 4 years ago

@urschrei can you take another look? Now that #39 is merged, we have an existing network feature flag. To me it seemed reasonable to run the network tests based on that flag, rather than introducing a separate run_network_tests flag.

WDYT?

I'd be happy to put it back in as a separate flag if you prefer.

urschrei commented 4 years ago

This looks good to me!

michaelkirk commented 4 years ago

bors r=urschrei

On Sep 8, 2020, at 05:26, Stephan Hügel notifications@github.com wrote:

 This looks good to me!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

bors[bot] commented 4 years ago

Build succeeded: