georust / proj

Rust bindings for the latest stable release of PROJ
https://docs.rs/proj
Apache License 2.0
137 stars 45 forks source link

Add feature to configure building with TIFF support. #58

Closed frewsxcv closed 3 years ago

frewsxcv commented 3 years ago

Thoughts? Would be a breaking change since it defaults to not building with TIFF support, and it used to

urschrei commented 3 years ago

I'm fine with it, but I think the network / grid download functionality requires libtiff – if we can't build with tiff support on M1, that's the fundamental problem.

urschrei commented 3 years ago

(Also, I'm in a writing hole until mid-next week, so I probably won't be able to do much other than talk about potential fixes)

urschrei commented 3 years ago

I think it's still an improvement to make tiff support optional (and probably contingent on the network feature). That potentially helps anyone not using the network feature and gives some way of building on M1.

You're absolutely correct.

frewsxcv commented 3 years ago

bors r=michaelkirk

bors[bot] commented 3 years ago

Build succeeded:

urschrei commented 3 years ago

\o/