search

georust / proj

Rust bindings for the latest stable release of PROJ
https://docs.rs/proj
Apache License 2.0
137 stars 45 forks source link

Use cargo-all-features to test all combinations of features #62

Closed frewsxcv closed 3 years ago

frewsxcv commented 3 years ago

WIP

michaelkirk commented 3 years ago

I really like cargo-test-all-features...

e.g. it caught this bug https://github.com/georust/wkt/pull/59#discussion_r575642395

It's currently pretty slow for the proj crate, but maybe that's OK. It'd be a real milestone if enough development was happening that CI became the bottleneck. 🙃

frewsxcv commented 3 years ago

@michaelkirk Well this PR is basically ready to go. I just wasn't sure about removing the _PROJ_SYS_TEST_EXPECT_BUILD_FROM_SRC test 🤷🏻

michaelkirk commented 3 years ago

I just wasn't sure about removing the _PROJ_SYS_TEST_EXPECT_BUILD_FROM_SRC test 🤷🏻

Oh right I forgot about that... I do like being able to test that we're building / not building from source.

I don't see how to reconcile that with cargo-test-all-features...

We could add another mostly-redundant cargo test-all-features job, just to make sure the compiler doesn't explode under any feature combinations, but I'm not sure if it's worth it.

sorry for the 🧇 🧇 🧇 🧇 🧇 🧇 🧇 🧇