search

georust / proj

Rust bindings for the latest stable release of PROJ
https://docs.rs/proj
Apache License 2.0
137 stars 45 forks source link

Update to PROJ 7.2.1 #70

Closed urschrei closed 3 years ago

urschrei commented 3 years ago

Let's see if this worked…

urschrei commented 3 years ago

bors try

urschrei commented 3 years ago

Is 🤖 not working today? Hmph.

michaelkirk commented 3 years ago

Probably you're just testing things - but wanted to make sure you didn't accidentally commit the unzipped proj source.

urschrei commented 3 years ago

I did wonder, but I don't think I did…I think GH unzips them for viewing. Hmm.

michaelkirk commented 3 years ago

Hmm... to me it looks like it's in the commit: 636 files changed, 419990 insertions(+), 11 deletions(-)

urschrei commented 3 years ago

Gremlins.

michaelkirk commented 3 years ago

Gremlins.

Lol, no doubt. Would you mind squashing that commit so that the add and delete don't bloat the repo and diff?

urschrei commented 3 years ago

OK done!

michaelkirk commented 3 years ago

LGTM!

I'll leave this to you to merge in case you had any magic Docker dance that needed doing.

urschrei commented 3 years ago

It should pass tests if (…) I've done the Docker dance right. Let's see.

urschrei commented 3 years ago

bors r+

urschrei commented 3 years ago

Ah, bors can't work with this PR because the bot can't interact with PRs that modify workflows: https://forum.bors.tech/t/resource-not-accessible-by-integration/408

I'm gonna move the workflow modification into a separate PR, merge it so the new Docker tag is in use, then rebase and try again. Worst-case scenario is that I discover that something's gone wrong with Docker and master is broken til I either revert the merge or fix it.

urschrei commented 3 years ago

bors try

bors[bot] commented 3 years ago

try

Already running a review

urschrei commented 3 years ago

bors r-

urschrei commented 3 years ago

bors try

bors[bot] commented 3 years ago

try

Already running a review

urschrei commented 3 years ago

bors try-

urschrei commented 3 years ago

bors try

bors[bot] commented 3 years ago

try

Build succeeded:

urschrei commented 3 years ago

\o/

bors r+

bors[bot] commented 3 years ago

Build failed:

urschrei commented 3 years ago

bors retry

bors[bot] commented 3 years ago

Build failed:

urschrei commented 3 years ago

NOW WHAT

urschrei commented 3 years ago

bors retry

bors[bot] commented 3 years ago

Build succeeded:

michaelkirk commented 3 years ago

NOW WHAT

🤣 go easy bors.

re: https://github.com/georust/proj/pull/70/commits/5e06534d378afb137be3867f7fb3873641c43a66

Do you understand that failure? Is it perhaps another flaky test indicative of some platform dependent heisenbug?

urschrei commented 3 years ago

I believe it's the same failure we saw on a different (also removed) test that used that Stereo70 string. I inherited it and (as discussed previously) PROJ strings can be finicky beasts, and I am now of the opinion that if I didn't write and validate it myself or get it from a canonical source then it's to be treated with suspicion. I'd like to replace it, just looking for something suitable rn.