search

georust / proj

Rust bindings for the latest stable release of PROJ
https://docs.rs/proj
Apache License 2.0
137 stars 45 forks source link

fix CI: macos was using proj8, which isn't supported #88

Closed michaelkirk closed 3 years ago

michaelkirk commented 3 years ago

proj8 seems to mostly work, but gives slightly different results. I'm not sure if this is a proj regression, or maybe "better" calculations from proj, or perhaps some problem with our integration.

edit: also took the opportunity to (update CI to the latest rust).

lnicola commented 3 years ago

Can we add georust/proj-ci:stable tags to avoid bumping these every time?

michaelkirk commented 3 years ago

Can we add georust/proj-ci:stable tags to avoid bumping these every time?

I think you've mentioned this before. You're welcome to propose this change to our ci docs and code which live here https://github.com/georust/docker-images. In the meanwhile I'm going to keep doing it this dumb way because bumping the tags is literally the easiest part.

The harder part is tracking down failures... like the fact that the macos package manager has updated their libproj beyond what we are testing against.

And now rust-1.53 is failing on ubuntu. Is this due to changes in rust 1.53 or the underlying ubuntu image? I don't know yet, but I don't think having an opaque moving tag like rust:stable would make any of that easier or solve a problem that I'm actually having.

lnicola commented 3 years ago

I think you've mentioned this before.

Oh, sorry. I'll try to not say it a third time, but please ignore me if I do :confused:.

michaelkirk commented 3 years ago

superceded by #89