Closed michaelkirk closed 2 years ago
bors try
I'm curious if the failing tests are just an aarch64 thing...
Oh yeah! Looks like tests have passed. I'm inclined to propose merging this as is, and leave the 3 failing tests as a separate change. I notice that I get different results when linking against proj 8.2 vs building proj 8.1 from source.
I notice that I get different results when linking against proj 8.2 vs building proj 8.1 from source.
It's reasonable to assume that it's a db update causing NaN values (as has been the case in the past) due to bounding box updates.
IIRC, kornel's Rust -sys library guide notes that pkg-config can be quite fussy. Homebrew's proj installs pkg-config but of course we can't make that assumption w/r/t/ Linux, so if we can do without it that's great.
Oh! For some reason I assumed all the linux distros relied on pkg-config and that it was just the mac and windows people that might be missing it.
Here's my proposal, if you're OK with it:
That sounds good to me!
bors r=urschrei
Slightly improves the situation at #57
On apple platforms, libtiff is not installed by the operating system. If the user has it installed, likely it was installed by homebrew.
Previously, on x86, homebrew installed libs into /usr/lib which is in the default search path, but since aarch64, homebrew has moved libs to /opt/homebrew/lib.
So now we use pkg-config to find the library.
Potential problems:
Note that proj enables tiff support by defeault, provided libtiff is found (using pkg-config? or something else?)
This is a draft because some tests are currently failing for me on aarch64. I'm looking into it now...
failing test output