georust / rstar

R*-tree spatial index for the Rust ecosystem
https://docs.rs/rstar
Apache License 2.0
414 stars 68 forks source link

Deprecate GeomWithData .inner() method in favour of Deref #122

Closed urschrei closed 1 year ago

urschrei commented 1 year ago

This matches the CachedEnvelope impl

adamreichold commented 1 year ago

Hhhmmm, I am admittedly not completely sure about this as GeomWithData is as much Geom as it is Data, so I don't think it is obvious that it should dereference into the geometry instead of the data part. Not sure whether this is really similar to the CachedEnvelope case where nothing is added conceptionally.

urschrei commented 1 year ago

Hmm good point. Let's abandon this for now…