search

georust / rstar

R*-tree spatial index for the Rust ecosystem
https://docs.rs/rstar
Apache License 2.0
415 stars 68 forks source link

Prepare for 0.11.0 release #126

Closed urschrei closed 1 year ago

urschrei commented 1 year ago
adamreichold commented 1 year ago

I think these are all non-breaking changes, right?

Technically, yes. But we did bump our MSRV. Personally, I find it impolite to do this in a patch release.

urschrei commented 1 year ago

@michaelkirk Yes my bad, but I think Adam makes a good point about the MSRV

rmanoka commented 1 year ago

Changes lgtm; agree with bumping to 0.11.0 as some compilation might break elsewhere.

urschrei commented 1 year ago

The "should MSRV be breaking" debate is pretty well trodden territory. I'm in the "it does more harm than good" camp, but I won't die on that hill this time.

I will note that this change brings us past the introduction of rust-version (introduced in 1.56), so future bumps to rust-version have no case for being a breaking semver bump as I understand it.

I for one am delighted that we can settle this issue using metadata.

urschrei commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.