georust / rstar

R*-tree spatial index for the Rust ecosystem
https://docs.rs/rstar
Apache License 2.0
384 stars 67 forks source link

Documentation about bulk load #155

Closed jerabaul29 closed 4 months ago

jerabaul29 commented 6 months ago

https://github.com/georust/rstar/blob/c7d53c81b7588a66d2a3763937862311f73ab7bd/rstar/src/rtree.rs#L98-L101

is still `O(log(n)): should that not be is still `O(n log(n)) for inserting n points, though the scaling factor is significantly improved?

jerabaul29 commented 6 months ago

(since this inserts n elements at once?)

rmanoka commented 6 months ago

Yes, the author probably meant O(log n) per element amortized.

jerabaul29 commented 6 months ago

I will open a PR to clarify :) .

grovesNL commented 4 months ago

@jerabaul29 looks like this is fixed now

jerabaul29 commented 4 months ago

Thanks, I just forgot to close this. Closing as solved through #156 .