Closed adamreichold closed 3 weeks ago
I'm for having this recursive impl. as an alternative to the iterator approach.
@adamreichold This is ready to merge, right? The only comment I have is that it would be good to have some brief documentation about when use of the new methods is preferable.
@adamreichold This is ready to merge, right? The only comment I have is that it would be good to have some brief documentation about when use of the new methods is preferable.
Yes, this is ready to go from my part. I can add the requested documentation, but do you have a preference where to put this? On the RTree
type discussing both approaches? On the new methods to contrast them with the existing ones?
I added some documentation on the type level discussing the selection methods and their alternative implementations using internal iteration.
[x] I added an entry to
rstar/CHANGELOG.md
if knowledge of this change could be valuable to users.This avoids the overhead of allocating an internal buffer to keep track of upcoming nodes when implementing the
Iterator
trait.I also found a mistake in the old code from #37 (lack of early return in the parent case) and now the benchmarks also look somewhat nicer, i.e. directly comparing internal and external iteration on the same data set:
Closes #163