georust / rstar

R*-tree spatial index for the Rust ecosystem
https://docs.rs/rstar
Apache License 2.0
410 stars 68 forks source link

Allow mutating generator functions for points #43

Closed Dr-Emann closed 3 years ago

Dr-Emann commented 4 years ago

This allows for additional flexibility for the caller, for example, code in the form of:

buffer = [f(), f(), f(), ..];
point = Point::generate(|i| buffer[i])

can be replaced with

point = Point::generate(|_| f())
adamreichold commented 4 years ago

The change to change log format seems unrelated should probably land in a separate PR?

Dr-Emann commented 4 years ago

Sure, I can move it into another PR. Where should I put the changelog entry for this unreleased version in this PR? Should I make a new "unreleased" section more closely matching the original format, and put it there, or make a new 0.9.0 section?

urschrei commented 3 years ago

@Dr-Emann Apologies for the long delay. We (georust) have taken over stewardship of this crate in order to facilitate maintenance and feature dev. If you're still interested, we'd like to get this merged – if you could rebase against master and update the changelog, we should be good to go.

Dr-Emann commented 3 years ago

Since it's a breaking change, should I change the changelog to be for 0.9.0?

urschrei commented 3 years ago

Sure!

Dr-Emann commented 3 years ago

Rebased on master

michaelkirk commented 3 years ago

bors r+

bors[bot] commented 3 years ago

Build succeeded: