search

georust / topojson

TopoJSON bindings and utilities for Rust
MIT License
10 stars 8 forks source link

Add support for geojson 0.23.0 #20

Closed pjsier closed 2 years ago

pjsier commented 2 years ago

Updates the version constraint on geojson to allow for version 0.23. I know there's been some conversation on other projects on the correct way of doing version constraints, so I'd be alright with changing this to 0.23.0 if that's the best practice

michaelkirk commented 2 years ago

AFAIK supporting a range of versions is the friendlier way to do it for your users. I think it's just harder to exhaustively test.

pjsier commented 2 years ago

Got it, thanks for clarifying! That was a good reminder to update the test matrix, forgot we had added that in to account for this

urschrei commented 2 years ago

bors try

urschrei commented 2 years ago

bors try

bors[bot] commented 2 years ago

try

Already running a review

urschrei commented 2 years ago

bors try

bors[bot] commented 2 years ago

try

Already running a review

urschrei commented 2 years ago

bors r-

urschrei commented 2 years ago

bors try

bors[bot] commented 2 years ago

try

Already running a review

urschrei commented 2 years ago

I am going to be talking to this bot forever.

pjsier commented 2 years ago

@urschrei are you alright with merging this manually since we're having issues with bors?

pjsier commented 2 years ago

@urschrei thanks! I've got crates.io access, am I good to push a release?

urschrei commented 2 years ago

If you're happy, sure!