search

georust / topojson

TopoJSON bindings and utilities for Rust
MIT License
10 stars 8 forks source link

Remove unhelpful warning and dependency on log crate #22

Closed dabreegster closed 8 months ago

dabreegster commented 1 year ago

When you call to_geojson on a large input with no feature IDs set, you currently see Ignoring feature id property because of invalid type spammed to logs. This doesn't seem like the most helpful or actionable warning to me, so this PR removes it entirely.

Alternatively, maybe it'd be more appropriate to show this warning only when feature ID is set to Some(x) but not a string or number?

dabreegster commented 8 months ago

Rebased. OK to merge?

lnicola commented 8 months ago

Um, who's the maintainer of this crate these days?

dabreegster commented 8 months ago

Hmm, you approved + merged the last few PRs. Just need to invoke bors, if the change looks OK?

lnicola commented 8 months ago

There's no more bors.

bors r+