search

georust / topojson

TopoJSON bindings and utilities for Rust
MIT License
10 stars 8 forks source link

Substantial rewrite to use serde and to be closer to the specs #6

Closed mthh closed 5 years ago

mthh commented 5 years ago

This is a major rewrite to use serde and to be closer to the TopoJson specifications (so it now accepts LineString and LinearRing composed of multiple Arcs in order to fix #2 for example; and it doesn't depends anymore on git dependencies as stated in #5).

I mostly tried to follow the same kind of patterns as in the geojson crate to handle topojson.

This PR includes basic documentation as well as a few test cases.

It let an examples folder with a few topojson files if someone wants to play with it while reviewing this PR (but it could be removed before merging it).

mthh commented 5 years ago

Many thanks for the review @KodrAus ! I left some comments on sections that I did not improve but otherwise I think I have taken into account the majority of your comments.

mthh commented 5 years ago

@frewsxcv @KodrAus do you have additional advice on what should be improved to see this PR merged ? Thanks !

frewsxcv commented 5 years ago

@mthh Yep! This is still on my radar, I'll try to review it in the next day or two

frewsxcv commented 5 years ago

bors r+

bors[bot] commented 5 years ago

Build succeeded