Support parse POINTZ, POINTM and POINTZM

georust / wkt

Rust read/write support for well-known text (WKT)

https://crates.io/crates/wkt

Apache License 2.0

51 stars 25 forks source link

Support parse POINTZ, POINTM and POINTZM #113

Closed ariesdevil closed 3 months ago

ariesdevil commented 7 months ago

[x] I agree to follow the project's code of conduct.
[ ] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.
[x] I ran cargo fmt

lnicola commented 7 months ago

I guess this will make the conversion to geo-types lossy. I don't think Z/M are available there, so there's not much you can do, just wanted to point that out.

ariesdevil commented 7 months ago

I guess this will make the conversion to geo-types lossy. I don't think Z/M are available there, so there's not much you can do, just wanted to point that out.↳

Thanks point it out, I see Coord in geo-types only support x and y, I think it needs to be refactored later.

ariesdevil commented 7 months ago

Fixed, PTAL again.

ariesdevil commented 7 months ago

You didn't add that comment about matches!, but whatever 😀.↳

Sorry, I forgot it🤔

michaelkirk commented 2 months ago

We've misspelled POINT Z, POINT M, and POINT ZM. See https://github.com/georust/wkt/issues/114

Can you take a look @ariesdevil?

Otherwise I think we should revert this.

georust / wkt

Support parse POINTZ, POINTM and POINTZM #113

[x] I ran cargo fmt