georust / wkt

Rust read/write support for well-known text (WKT)
https://crates.io/crates/wkt
Apache License 2.0
50 stars 25 forks source link

Migrate to 2021 edition and add examples #71

Closed urschrei closed 2 years ago

urschrei commented 2 years ago
lnicola commented 2 years ago

We could go right to 2021, I think?

urschrei commented 2 years ago

Oh, I was just being conservative because nothing else in georust is 2021 yet

lnicola commented 2 years ago

Might be a good place to start, since wkt isn't tested on older compilers :smile:.

urschrei commented 2 years ago

Well I guess we know it doesn't work.

lnicola commented 2 years ago

We need something like:

    - name: Install Rust toolchain
      uses: actions-rs/toolchain@v1
      with:
        toolchain: stable
        profile: minimal
        override: true
        components: rustfmt, rust-src
urschrei commented 2 years ago

Should I add a doc entry for the serde feature? Is it in use? I didn't know WKT-in-JSON was something people did.

nm I did it.

urschrei commented 2 years ago

Two last things I'd like to nail down:

nyurik commented 2 years ago

@urschrei should this be merged? There are two approvals, but no merge, so high chance of bitrot

urschrei commented 2 years ago

Oh, yeah. I think I was just leaving it for a few days.

urschrei commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded: