search

georust / wkt

Rust read/write support for well-known text (WKT)
https://crates.io/crates/wkt
Apache License 2.0
50 stars 25 forks source link

Make geo-types a non-optional dependency #74

Closed urschrei closed 2 years ago

urschrei commented 2 years ago

As part of #71 I've written some examples. However, the most simple "practical" example uses geo-types, which is enabled by default, but optional, which means we can't run --no-default-features in tests (The use of unstable nightly features notwithstanding).

Is there a reason to keep geo-types as an optional feature? Are there existing uses cases which don't make use of geo-types? Is it likely that potential users of the crate will be put off by a dependency on geo-types?

lnicola commented 2 years ago

I'm quite in favour of this. I'm generally worried about compile times, but geo-types isn't that bad:

image

pka commented 2 years ago

I'm for leaving geo-types as default feature. This enables using the WKT parser for other geometry implementations (like geozero) without unnecessary dependencies.

urschrei commented 2 years ago

Keeping it optional for now!