search

geoschem / Cloud-J

Cloud-J is multi-scattering eight-stream radiative transfer model for solar radiation based on Fast-J. It was originally developed by Michael J. Prather.
GNU General Public License v3.0
3 stars 6 forks source link

Cloud-J v8 #12

Open lizziel opened 3 months ago

lizziel commented 3 months ago

The main development branch is currently Cloud-J v7.7 from @pratherUCI with some additional updates such as CMake build system. After https://github.com/geoschem/Cloud-J/pull/2 is merged it will also have no diff updates for compatibility within GEOS-Chem Classic and GCHP, as well as GEOS-Chem within the GEOS and CESM earth system models. I will tag that version v7.7.1.

@pratherUCI has a newer version of Cloud-J that we will put into this repository. He writes:

The next version of Cloud-J standalone is v8.0c, it has been changed (minorly) to include H2O absorption. At the time I also went through all the old commons and removed dead variables (as you did). I will check my list. So how is best to proceed. BTW, this code enabled me to include NO2 absorption (small effects vs H2O). The major change is in one input table, a few lines of code, and then the clean up. This is not urgent, the only change is the H2O abs. Prather, Michael (2023). An updated cloud-overlap photolysis module for atmospheric chemistry models, UCI Cloud-J v8.0, with near-UV H2O absorption [Dataset]. Dryad. https://doi.org/10.7280/D1Q398

I believe I have all of the files for v8.0c (@pratherUCI, let me know if they have changed since you posted on Google Drive). The best way to get these into the model would be for me to create a branch off of my original commit, copy in those files, merge in the latest Cloud-J, and create a PR. That should isolate the science differences. There will be merge conflicts but I am familiar enough with the code to resolve them, and can reach out with any questions. I will make @pratherUCI a reviewer to make sure nothing is missed.

There are also several no diff code improvements suggested by @yantosca in his review of https://github.com/geoschem/Cloud-J/pull/2. These can go into a Z version at any time.

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.