search

geoschem / Cloud-J

Cloud-J is multi-scattering eight-stream radiative transfer model for solar radiation based on Fast-J. It was originally developed by Michael J. Prather.
GNU General Public License v3.0
3 stars 6 forks source link

Mac build #18

Closed K20shores closed 2 days ago

K20shores commented 2 weeks ago

Name and Institution (Required)

Name: Kyle Shores Institution: National Center for Atmospheric Research

Describe the update

Adds a github action to build CloudJ on mac with gcc 11, 12, and 13. Some of the cmake files also had to be modified to make it work

Expected changes

There shouldn't be any since there were no code changes. However, when I run the standalone binary, I get a segfault on mac

Reference(s)

None

Related Github Issues and PRs

None

lizziel commented 2 weeks ago

@K20shores, making sure I am understanding correctly that your updates to the standalone CMakeLists.txt fix your seg fault issue. True?

K20shores commented 2 weeks ago

@lizziel sorry, I was imprecise with my language. Even with these changes I was seeing the segfault. But that went away when I removed the stack frame limit with ulimit -s unlimited as suggested in the readme.

lizziel commented 2 days ago

@K20shores, could you update the changelog?

K20shores commented 2 days ago

@lizziel done! Sorry for missing that the first time around

lizziel commented 2 days ago

Thanks!