search

geoschem / Cloud-J

Cloud-J is multi-scattering eight-stream radiative transfer model for solar radiation based on Fast-J. It was originally developed by Michael J. Prather.
GNU General Public License v3.0
3 stars 7 forks source link

Ubuntu Action #9

Closed K20shores closed 7 months ago

K20shores commented 7 months ago

This adds a github workflow that builds Cloud-J on ubuntu in debug and release mode with GNU

I had also tried to build on macOS and windows. The macOS build was failing for reasons unrelated to CloudJ and I couldn't figure out how to install netcdf-fortran on windows quickly. But I may put more time into either of those over the coming quarter. Hopefully this can help you identify build issues on different platforms as we start to integrate CloudJ with more NCAR software products

lizziel commented 7 months ago

Thanks @K20shores! I am tagging @yantosca who is also on the GEOS-Chem Support Team to review.

lizziel commented 7 months ago

@K20shores, heads up I have a cesm/dev branch in Cloud-J. Look at that one instead of main if you are browsing the code to assess needs for MUSICA. I need to do some work on the Cloud-J standalone data tables before bringing the more recent Cloud-J development work in.

K20shores commented 7 months ago

@lizziel or @yantosca would you mind checking to see if github actions are enabled for this repository?

lizziel commented 7 months ago

GitHub actions are enabled.

K20shores commented 7 months ago

@lizziel I'm not sure why the actions won't run, maybe it's because they aren't yet in this repository. You can see that they run and pass in a PR on my fork though: https://github.com/K20shores/Cloud-J/pull/1

yantosca commented 7 months ago

@K20shores maybe it won't run until the PR is merged into the main branch. We could check this by pulling into a dev branch and then seeing if the PR can be started manually.

lizziel commented 7 months ago

Yes, I don't think the action will run unless it is merged in. I will go ahead and merge. If a fix is needed we can bring it in immediately.